If you take a close look at the effects smoking can have on your singing voice, there is no one truth. There is some scientific proof, smoking over several years, can cause vocal edemas, which results in a lower voice.
Does smoking make you sing better?
This has been said to have an affect on your vocal range, often leading to a deeper voice and an inability to hit certain high notes can be a result. If you want a deeper voice, then smoking can help your singing, but for most people, smoking and singing should be avoided – for more than just performance reasons!
Can smoking ruin your singing voice?
The final major impact of smoking on your singing ability comes down to the swelling of the vocal folds when you smoke. ... This also contributes the raspy quality heavily smoke-damaged voices get. The problems are even bigger for smoking and your singing voice when it comes to swelling, though.